Review Request 108444: Fix cash on creating new character style

Pierre Stirnweiss pstirnweiss at googlemail.com
Thu Jan 17 18:08:52 GMT 2013


yes it's for 2.6, attached a diff with a rebased 2.6

On Thu, Jan 17, 2013 at 6:38 PM, Friedrich W. H. Kossebau
<kossebau at kde.org>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108444/
>
> Is that for 2.6 or master (bug was for 2.6)? Did not apply cleanly for me against 2.6 at least.
>
>
> - Friedrich W. H.
>
> On January 16th, 2013, 8:45 p.m. UTC, Pierre Stirnweiss wrote:
>   Review request for Calligra and Friedrich W. H. Kossebau.
> By Pierre Stirnweiss.
>
> *Updated Jan. 16, 2013, 8:45 p.m.*
> Description
>
> When creating a new character style, Words crashed because an null pointer was passed around and used. Also, the name of the style was not updated.
>
>   *Bugs: * 313233 <http://bugs.kde.org/show_bug.cgi?id=313233>
> Diffs
>
>    - plugins/textshape/dialogs/StylesModel.cpp (80ea48d)
>    - plugins/textshape/dialogs/StyleManager.cpp (c561d35)
>    - plugins/textshape/dialogs/StyleManager.h (a45a58a)
>    - plugins/textshape/dialogs/FormattingPreview.cpp (1ed3b83)
>    - plugins/textshape/dialogs/CharacterGeneral.cpp (d3eead6)
>
> View Diff <http://git.reviewboard.kde.org/r/108444/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130117/3d5b7752/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-fixCrashOnCreateNewCharStyle2
Type: application/octet-stream
Size: 9258 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130117/3d5b7752/attachment.obj>


More information about the calligra-devel mailing list