Review Request 108444: Fix cash on creating new character style

Friedrich W. H. Kossebau kossebau at kde.org
Thu Jan 17 17:38:05 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108444/#review25726
-----------------------------------------------------------


Is that for 2.6 or master (bug was for 2.6)? Did not apply cleanly for me against 2.6 at least.

- Friedrich W. H. Kossebau


On Jan. 16, 2013, 8:45 p.m., Pierre Stirnweiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108444/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 8:45 p.m.)
> 
> 
> Review request for Calligra and Friedrich W. H. Kossebau.
> 
> 
> Description
> -------
> 
> When creating a new character style, Words crashed because an null pointer was passed around and used. Also, the name of the style was not updated.
> 
> 
> This addresses bug 313233.
>     http://bugs.kde.org/show_bug.cgi?id=313233
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/dialogs/StylesModel.cpp 80ea48d 
>   plugins/textshape/dialogs/StyleManager.cpp c561d35 
>   plugins/textshape/dialogs/StyleManager.h a45a58a 
>   plugins/textshape/dialogs/FormattingPreview.cpp 1ed3b83 
>   plugins/textshape/dialogs/CharacterGeneral.cpp d3eead6 
> 
> Diff: http://git.reviewboard.kde.org/r/108444/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130117/7b44dc64/attachment.htm>


More information about the calligra-devel mailing list