calligra-devel Digest, Vol 27, Issue 34

Fri Jan 11 11:04:37 GMT 2013

On 1/11/13, calligra-devel-request at kde.org
<calligra-devel-request at kde.org> wrote:
> Send calligra-devel mailing list submissions to
> 	calligra-devel at kde.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> 	https://mail.kde.org/mailman/listinfo/calligra-devel
> or, via email, send a message with subject or body 'help' to
> 	calligra-devel-request at kde.org
>
> You can reach the person managing the list at
> 	calligra-devel-owner at kde.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of calligra-devel digest..."
>
>
> Today's Topics:
>
>    1. Re: Review Request: Readd formats menu (Select Masterpage,
>       Edit Page layout) to Flow (Commit Hook)
>    2. Re: Review Request: Improved VisualImageCompare #2
>       (Thorsten Zachmann)
>    3. Re: Review Request: Readd formats menu (Select Masterpage,
>       Edit Page layout) to Flow (Commit Hook)
>    4. An other RC ? (Cyrille Berger)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Thu, 10 Jan 2013 22:34:08 -0000
> From: "Commit Hook" <null at kde.org>
> To: "Yue Liu" <yue.liu at mail.com>
> Cc: Commit Hook <null at kde.org>, Calligra <calligra-devel at kde.org>
> Subject: Re: Review Request: Readd formats menu (Select Masterpage,
> 	Edit Page layout) to Flow
> Message-ID: <20130110223408.29467.5411 at vidsolbach.de>
> Content-Type: text/plain; charset="utf-8"
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108220/#review25198
> -----------------------------------------------------------
>
>
> This review has been submitted with commit
> 65d73beb74da02368c03d4a0b4066f163270269a by Friedrich W. H. Kossebau to
> branch master.
>
> - Commit Hook
>
>
> On Jan. 6, 2013, 4:03 a.m., Friedrich W. H. Kossebau wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/108220/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 6, 2013, 4:03 a.m.)
>>
>>
>> Review request for Calligra and Yue Liu.
>>
>>
>> Description
>> -------
>>
>> KoPAView::initActions() is adding actions for selecting the "Master
>> Page..." and setting the "Page Layout...", but they do not make it into
>> the menu of Calligra Flow, because the flow.rc misses to have the proper
>> entries "format_masterpage" and "format_pagelayout" (and these are also
>> not part of "ui_standards.rc").
>>
>> Attached patch adds a menu "Format" with the two entries, for consistency
>> like Stage has (though Stage adds own menu entries as well).
>>
>> Okay to also backport to 2.6?
>>
>> There is one flaw, but that also exist with Stage now: switching to
>> another format does not trigger a repaint. Has to be fixed separately.
>>
>>
>> Diffs
>> -----
>>
>>   flow/part/flow.rc 3e90a63
>>
>> Diff: http://git.reviewboard.kde.org/r/108220/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Friedrich W. H. Kossebau
>>
>>
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://mail.kde.org/pipermail/calligra-devel/attachments/20130110/c3290d02/attachment-0001.html>
>
> ------------------------------
>
> Message: 2
> Date: Fri, 11 Jan 2013 03:11:52 -0000
> From: "Thorsten Zachmann" <t.zachmann at zagge.de>
> To: "Thorsten Zachmann" <t.zachmann at zagge.de>
> Cc: Calligra <calligra-devel at kde.org>, Mohammed Nafees
> 	<nafees.technocool at gmail.com>
> Subject: Re: Review Request: Improved VisualImageCompare #2
> Message-ID: <20130111031152.23047.93262 at vidsolbach.de>
> Content-Type: text/plain; charset="utf-8"
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108322/#review25212
> -----------------------------------------------------------
>
>
> Nice work. Please fix the thinks I pointed out. Then we are ready to take it
> in.
>
>
> tools/cstester/visualimagecompare/CSTCompareView.cpp
> <http://git.reviewboard.kde.org/r/108322/#comment19257>
>
>     The variable is no longer used. Please remove.
>
>
>
> tools/cstester/visualimagecompare/CSTCompareView.cpp
> <http://git.reviewboard.kde.org/r/108322/#comment19259>
>
>     Please change the Preferred to Ingnored. Only with that change it works
> without expanding for me.
>
>
>
> tools/cstester/visualimagecompare/CSTCompareView.cpp
> <http://git.reviewboard.kde.org/r/108322/#comment19258>
>
>     This method is no longer needed. Please remove.
>
>
> - Thorsten Zachmann
>
>
> On Jan. 10, 2013, 6:30 p.m., Mohammed Nafees wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/108322/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 10, 2013, 6:30 p.m.)
>>
>>
>> Review request for Calligra and Thorsten Zachmann.
>>
>>
>> Description
>> -------
>>
>> http://www.google-melange.com/gci/task/view/google/gci2012/8034206
>>
>> The window does not resize when the document name is longer than the
>> window. The full title is still visible. The user also can see the total
>> number of files that have changes.
>>
>>
>> Diffs
>> -----
>>
>>   tools/cstester/visualimagecompare/CSTCompareView.h 132f6d8
>>   tools/cstester/visualimagecompare/CSTCompareView.cpp 6bf118c
>>
>> Diff: http://git.reviewboard.kde.org/r/108322/diff/
>>
>>
>> Testing
>> -------
>>
>> yes
>>
>>
>> Thanks,
>>
>> Mohammed Nafees
>>
>>
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://mail.kde.org/pipermail/calligra-devel/attachments/20130111/1f60b1d8/attachment-0001.html>
>
> ------------------------------
>
> Message: 3
> Date: Fri, 11 Jan 2013 08:20:51 -0000
> From: "Commit Hook" <null at kde.org>
> To: "Yue Liu" <yue.liu at mail.com>
> Cc: Commit Hook <null at kde.org>, Calligra <calligra-devel at kde.org>
> Subject: Re: Review Request: Readd formats menu (Select Masterpage,
> 	Edit Page layout) to Flow
> Message-ID: <20130111082051.26643.17475 at vidsolbach.de>
> Content-Type: text/plain; charset="utf-8"
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108220/#review25227
> -----------------------------------------------------------
>
>
> This review has been submitted with commit
> 68355b7573b735c1731e041c1fb2481e82afeff9 by Friedrich W. H. Kossebau to
> branch calligra/2.6.
>
> - Commit Hook
>
>
> On Jan. 6, 2013, 4:03 a.m., Friedrich W. H. Kossebau wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/108220/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 6, 2013, 4:03 a.m.)
>>
>>
>> Review request for Calligra and Yue Liu.
>>
>>
>> Description
>> -------
>>
>> KoPAView::initActions() is adding actions for selecting the "Master
>> Page..." and setting the "Page Layout...", but they do not make it into
>> the menu of Calligra Flow, because the flow.rc misses to have the proper
>> entries "format_masterpage" and "format_pagelayout" (and these are also
>> not part of "ui_standards.rc").
>>
>> Attached patch adds a menu "Format" with the two entries, for consistency
>> like Stage has (though Stage adds own menu entries as well).
>>
>> Okay to also backport to 2.6?
>>
>> There is one flaw, but that also exist with Stage now: switching to
>> another format does not trigger a repaint. Has to be fixed separately.
>>
>>
>> Diffs
>> -----
>>
>>   flow/part/flow.rc 3e90a63
>>
>> Diff: http://git.reviewboard.kde.org/r/108220/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Friedrich W. H. Kossebau
>>
>>
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://mail.kde.org/pipermail/calligra-devel/attachments/20130111/ad25df96/attachment-0001.html>
>
> ------------------------------
>
> Message: 4
> Date: Fri, 11 Jan 2013 09:34:33 +0100
> From: Cyrille Berger <cberger at cberger.net>
> To: <calligra-devel at kde.org>
> Subject: An other RC ?
> Message-ID: <c5416f113e5804898f704fb0a9d46979 at diwi.org>
> Content-Type: text/plain; charset=UTF-8; format=flowed
>
> Hi,
>
> Since Casper discovered some really bad bugs in calligra sheets, even
> though they are not regressions, it still might be worth to have an
> extra "RC" to make sure that fixing those bugs don't introduce
> regressions. So if there is no objection, proposed updated schedule:
>
> 12th -> "RC"3 tag
> 15th -> "RC"3 release
>
> 2nd February -> final tag
> 5th -> final release
>
> --
> Cyrille Berger Skott
>
>
> ------------------------------
>
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
>
>
> End of calligra-devel Digest, Vol 27, Issue 34
> **********************************************
>

-- 
Sent from my mobile device

Regards,
Abhishek B S