Review Request: Make KoReport section editor dialogs use QDialogButtonBox

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108096/#review24521
-----------------------------------------------------------


I compiled/checked your changes, thanks for attention to details.

1. How about using KDialogButtonBox instead of QDialogButtonBox? (it's available in Qt Designer too)

2. While we're moving to QFormLayout I propose to fix checkboxes in one go, see http://wstaw.org/m/2013/01/02/plasma-desktopnq2207.png
i.e. "Show Group Header" -> "Show group header:", etc. 

3. BTW, please fix capitalization in the same patch, all 3 check boxes mentioned above need this fix, and also 12 checkboxes in the Section Editor

4. I propose to replace the Add/Edit/Delete/MoveUp/MoveDown buttons with once created programatically using the KPushButton(const KGuiItem &, ..) ctor, by using KStandardGuiItem::add() and KStandardGuiItem::del() and also setting icons arrow-up/arrow-down for MoveUp/MoveDown KPushButtons.

5. Bug tah can be easily fixed: Clicking "Add" and then Cancel should not leave empty Section item on the list; the item should be added only after accepting the Group Section Dialog.


- Jarosław Staniek


On Jan. 2, 2013, 9:29 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108096/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 9:29 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Patch replaces the carefully handcrafted ok/cancel/close buttons of SectionEditor and DetailGroupSectionDialog with some off-the-shelf ones, how boring ;)
> 
> But consistency might rule here as well. While I was at it, I changed one gridlayout to a formlayout and changed some strings to more usual usage:
> * "Sort" ? "Sort:"
> * "Add" ? "Add..." and "Edit" ? "Edit...", as dialogs are opened on click.
> 
> Also removed any manually set spacings/margins, besides the 0 margins, looks less strange now.
> 
> Okay?
> 
> And okay to backport to 2.6, without the string changes?
> 
> 
> Diffs
> -----
> 
>   libs/koreport/wrtembed/detailgroupsectiondialog.cpp ec0c84c 
>   libs/koreport/wrtembed/detailgroupsectiondialog.ui 32f4700 
>   libs/koreport/wrtembed/sectioneditor.cpp e7b9205 
>   libs/koreport/wrtembed/sectioneditor.ui ba9a337 
> 
> Diff: http://git.reviewboard.kde.org/r/108096/diff/
> 
> 
> Testing
> -------
> 
> Used in Kexi, worked as before.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130102/e42616ab/attachment.htm>