Review Request: Make KoReport section editor dialogs use QDialogButtonBox

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108096/
-----------------------------------------------------------

Review request for Calligra, Jarosław Staniek and Adam Pigg.


Description
-------

Patch replaces the carefully handcrafted ok/cancel/close buttons of SectionEditor and DetailGroupSectionDialog with some off-the-shelf ones, how boring ;)

But consistency might rule here as well. While I was at it, I changed one gridlayout to a formlayout and changed some strings to more usual usage:
* "Sort" ? "Sort:"
* "Add" ? "Add..." and "Edit" ? "Edit...", as dialogs are opened on click.

Also removed any manually set spacings/margins, besides the 0 margins, looks less strange now.

Okay?

And okay to backport to 2.6, without the string changes?


Diffs
-----

  libs/koreport/wrtembed/detailgroupsectiondialog.cpp ec0c84c 
  libs/koreport/wrtembed/detailgroupsectiondialog.ui 32f4700 
  libs/koreport/wrtembed/sectioneditor.cpp e7b9205 
  libs/koreport/wrtembed/sectioneditor.ui ba9a337 

Diff: http://git.reviewboard.kde.org/r/108096/diff/


Testing
-------

Used in Kexi, worked as before.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130102/9dce681d/attachment.htm>