<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108096/">http://git.reviewboard.kde.org/r/108096/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I compiled/checked your changes, thanks for attention to details.
1. How about using KDialogButtonBox instead of QDialogButtonBox? (it's available in Qt Designer too)
2. While we're moving to QFormLayout I propose to fix checkboxes in one go, see http://wstaw.org/m/2013/01/02/plasma-desktopnq2207.png
i.e. "Show Group Header" -> "Show group header:", etc.
3. BTW, please fix capitalization in the same patch, all 3 check boxes mentioned above need this fix, and also 12 checkboxes in the Section Editor
4. I propose to replace the Add/Edit/Delete/MoveUp/MoveDown buttons with once created programatically using the KPushButton(const KGuiItem &, ..) ctor, by using KStandardGuiItem::add() and KStandardGuiItem::del() and also setting icons arrow-up/arrow-down for MoveUp/MoveDown KPushButtons.
5. Bug tah can be easily fixed: Clicking "Add" and then Cancel should not leave empty Section item on the list; the item should be added only after accepting the Group Section Dialog.
</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On January 2nd, 2013, 9:29 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Jarosław Staniek and Adam Pigg.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Jan. 2, 2013, 9:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch replaces the carefully handcrafted ok/cancel/close buttons of SectionEditor and DetailGroupSectionDialog with some off-the-shelf ones, how boring ;)
But consistency might rule here as well. While I was at it, I changed one gridlayout to a formlayout and changed some strings to more usual usage:
* "Sort" ? "Sort:"
* "Add" ? "Add..." and "Edit" ? "Edit...", as dialogs are opened on click.
Also removed any manually set spacings/margins, besides the 0 margins, looks less strange now.
Okay?
And okay to backport to 2.6, without the string changes?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used in Kexi, worked as before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/wrtembed/detailgroupsectiondialog.cpp <span style="color: grey">(ec0c84c)</span></li>
<li>libs/koreport/wrtembed/detailgroupsectiondialog.ui <span style="color: grey">(32f4700)</span></li>
<li>libs/koreport/wrtembed/sectioneditor.cpp <span style="color: grey">(e7b9205)</span></li>
<li>libs/koreport/wrtembed/sectioneditor.ui <span style="color: grey">(ba9a337)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108096/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>