Review Request: Have ok/cancel buttons consistently at the bottom in dialogs, not the right side

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108066/
-----------------------------------------------------------

(Updated Jan. 2, 2013, 5:54 p.m.)


Review request for Calligra and Marijn Kruisselbrink.


Changes
-------

Updated with changes to Sheets' StyleManagerDialog & NamedAreaDialog, now there is no more call to KDialog::setButtonsOrientation(Qt::Vertical); in Calligra code.

Naming/text of buttons is a separate issue, so not dealing with that here.


Description
-------

A few dialogs in Sheets have the general buttons on the right side, not the bottom like these days almost all (KDE) dialogs have.

I would propose to have change those few dialogs to have the buttons at the bottom as well,
even if the dialog then uses more space as needed in that compact form.

Attached patch fixes that for the CSV export dialog and the Conditional Styles dialog, as that is a simple one-line removal.

The other two places, Named Area dialog and Style Manager dialog, would need some more work, so I first wait for the okay before I post a patch for review here for those as well.

So okay to commit the attached patch and start work to change the two other dialogs as well?

Any other place known with buttons at the right side instead of the bottom (might be no KDialog-derived ones)?


Diffs (updated)
-----

  filters/sheets/csv/csvexportdialog.cpp d2fd2fc 
  sheets/dialogs/ConditionalDialog.cpp f5b1e26 
  sheets/dialogs/NamedAreaDialog.h 79817b0 
  sheets/dialogs/NamedAreaDialog.cpp d9c1aa9 
  sheets/dialogs/StyleManagerDialog.h c760af6 
  sheets/dialogs/StyleManagerDialog.cpp c97af27 

Diff: http://git.reviewboard.kde.org/r/108066/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130102/fcf848af/attachment.htm>