Review Request: Have ok/cancel buttons consistently at the bottom in dialogs, not the right side

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108066/
-----------------------------------------------------------

(Updated Jan. 2, 2013, 5:57 p.m.)


Review request for Calligra and Marijn Kruisselbrink.


Description (updated)
-------

A few dialogs in Sheets have the general buttons on the right side, not the bottom like these days almost all (KDE) dialogs have.

I would propose to have change those few dialogs to have the buttons at the bottom as well,
even if the dialog then uses more space as needed in that compact form.

Attached patch fixes that for the CSV export dialog and the Conditional Styles dialog, Named Area dialog and Style Manager dialog.

Okay to commit?

Also backport to 2.6? No string changes involved, can be considered a UI fix.


Diffs
-----

  filters/sheets/csv/csvexportdialog.cpp d2fd2fc 
  sheets/dialogs/ConditionalDialog.cpp f5b1e26 
  sheets/dialogs/NamedAreaDialog.h 79817b0 
  sheets/dialogs/NamedAreaDialog.cpp d9c1aa9 
  sheets/dialogs/StyleManagerDialog.h c760af6 
  sheets/dialogs/StyleManagerDialog.cpp c97af27 

Diff: http://git.reviewboard.kde.org/r/108066/diff/


Testing (updated)
-------

All dialogs work as before, when played around with them.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130102/bde81ec6/attachment.htm>