<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108066/">http://git.reviewboard.kde.org/r/108066/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Marijn Kruisselbrink.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Jan. 2, 2013, 5:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated with changes to Sheets' StyleManagerDialog & NamedAreaDialog, now there is no more call to KDialog::setButtonsOrientation(Qt::Vertical); in Calligra code.
Naming/text of buttons is a separate issue, so not dealing with that here.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A few dialogs in Sheets have the general buttons on the right side, not the bottom like these days almost all (KDE) dialogs have.
I would propose to have change those few dialogs to have the buttons at the bottom as well,
even if the dialog then uses more space as needed in that compact form.
Attached patch fixes that for the CSV export dialog and the Conditional Styles dialog, as that is a simple one-line removal.
The other two places, Named Area dialog and Style Manager dialog, would need some more work, so I first wait for the okay before I post a patch for review here for those as well.
So okay to commit the attached patch and start work to change the two other dialogs as well?
Any other place known with buttons at the right side instead of the bottom (might be no KDialog-derived ones)?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/sheets/csv/csvexportdialog.cpp <span style="color: grey">(d2fd2fc)</span></li>
<li>sheets/dialogs/ConditionalDialog.cpp <span style="color: grey">(f5b1e26)</span></li>
<li>sheets/dialogs/NamedAreaDialog.h <span style="color: grey">(79817b0)</span></li>
<li>sheets/dialogs/NamedAreaDialog.cpp <span style="color: grey">(d9c1aa9)</span></li>
<li>sheets/dialogs/StyleManagerDialog.h <span style="color: grey">(c760af6)</span></li>
<li>sheets/dialogs/StyleManagerDialog.cpp <span style="color: grey">(c97af27)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108066/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>