Review Request 110700: Remove unused storage/API from StyleManager

[Elvis Stansvik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110700/
-----------------------------------------------------------

(Updated Aug. 4, 2013, 12:36 p.m.)


Status
------

This change has been discarded.


Review request for Calligra, C. Boemann, Gopalakrishna Bhat, Pierre Stirnweiss, and Thorsten Zachmann.


Description
-------

In KoStyleManager, nothing is ever added to the d->unusedParagraphStyles hash, so I suggest we remove it along with the accompanying API.

I'm guessing it was an unfinished attempt to make ToC/bibliography styles not appear at all in the UI until they're used (I mean, not even appear as "Unused") ?

The code that used the API were the bibliography and ToC templates, but nothing was ever inserted into d->unusedParagraphStyles.


Diffs
-----

  libs/kotext/styles/KoStyleManager.h c44ba32 
  libs/kotext/styles/KoStyleManager.cpp f7b9b5f 
  libs/textlayout/ToCGenerator.cpp 30df21e 
  plugins/textshape/dialogs/BibliographyTemplate.h 99ca6c4 
  plugins/textshape/dialogs/BibliographyTemplate.cpp 4bb2bd0 
  plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp c93a673 
  plugins/textshape/dialogs/SimpleTableOfContentsWidget.cpp 48fb88e 
  plugins/textshape/dialogs/TableOfContentsTemplate.h f98f6f9 
  plugins/textshape/dialogs/TableOfContentsTemplate.cpp 2bd73e7 

Diff: http://git.reviewboard.kde.org/r/110700/diff/


Testing
-------

Tested bibliography functionality before/after the removal. There was no change in behavior that I could see.


Thanks,

Elvis Stansvik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130804/703fefd2/attachment.htm>