Review Request 110408: Improve the styles handling in libs/odf/styles

Inge Wallin inge at lysator.liu.se
Sun Aug 4 13:10:39 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110408/
-----------------------------------------------------------

(Updated Aug. 4, 2013, 12:10 p.m.)


Status
------

This change has been discarded.


Review request for Calligra and Matus Uzak.


Description
-------

This is the second step in the quest to improve styles handling in Calligra.  This patch introduces text-properties, paragraph-properties and graphic-properties in the styles, which means that more specific information than only attributes. The style:text-properties element don't have any child elements but paragraph-properties do (background-image, drop-cap and tab-stops) and also graphic-properties.

Not everything is implemented yet but I wanted to support style:background-image in libs/odf for the styles that are already in use everywhere before implementing it here.

In the short term, this is important for the docx filter, and to save back named styles in Karbon and styles with family=graphic in all applications.


Diffs
-----

  libs/odf/CMakeLists.txt b3940c1 
  libs/odf/styles/KoOdfGraphicProperties.h PRE-CREATION 
  libs/odf/styles/KoOdfGraphicProperties.cpp PRE-CREATION 
  libs/odf/styles/KoOdfParagraphProperties.h PRE-CREATION 
  libs/odf/styles/KoOdfParagraphProperties.cpp PRE-CREATION 
  libs/odf/styles/KoOdfStyle.cpp aac9ea2 
  libs/odf/styles/KoOdfStyleProperties.h 9453989 
  libs/odf/styles/KoOdfStyleProperties.cpp 7a34bf9 
  libs/odf/styles/KoOdfTextProperties.h PRE-CREATION 
  libs/odf/styles/KoOdfTextProperties.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110408/diff/


Testing
-------


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130804/e6f8f1b4/attachment.htm>


More information about the calligra-devel mailing list