Review Request: Make Paragraph Format dialog use KoStyleThumbnailer

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104919/#review13732
-----------------------------------------------------------

Ship it!


Very good, and not even a single thing I could pick on.


plugins/textshape/dialogs/ParagraphGeneral.cpp
<http://git.reviewboard.kde.org/r/104919/#comment10908>

    nice catch


- C. Boemann


On May 11, 2012, 6:57 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104919/
> -----------------------------------------------------------
> 
> (Updated May 11, 2012, 6:57 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This change enables us to use the actual textlayout code to render previews. This approach also enables us to remove a lot of redundant code that was there to substitute the layout process.
> 
> 
> Diffs
> -----
> 
>   libs/textlayout/KoStyleThumbnailer.h 42c3c6d 
>   libs/textlayout/KoStyleThumbnailer.cpp acb836d 
>   plugins/textshape/dialogs/CharacterGeneral.h bb72b88 
>   plugins/textshape/dialogs/CharacterGeneral.cpp 4923087 
>   plugins/textshape/dialogs/FormattingPreview.h 5a67d48 
>   plugins/textshape/dialogs/FormattingPreview.cpp 6103699 
>   plugins/textshape/dialogs/ParagraphBulletsNumbers.h 03c5cc9 
>   plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp 2d365f8 
>   plugins/textshape/dialogs/ParagraphDecorations.h 0eea7cc 
>   plugins/textshape/dialogs/ParagraphDecorations.cpp b5c4d94 
>   plugins/textshape/dialogs/ParagraphDropCaps.h 7c7b071 
>   plugins/textshape/dialogs/ParagraphDropCaps.cpp 6696254 
>   plugins/textshape/dialogs/ParagraphGeneral.h 5ef5c86 
>   plugins/textshape/dialogs/ParagraphGeneral.cpp 8ef5b7f 
>   plugins/textshape/dialogs/ParagraphIndentSpacing.h 27533e0 
>   plugins/textshape/dialogs/ParagraphIndentSpacing.cpp 5227d55 
>   plugins/textshape/dialogs/ParagraphLayout.h be272ee 
>   plugins/textshape/dialogs/ParagraphLayout.cpp 7b46f00 
> 
> Diff: http://git.reviewboard.kde.org/r/104919/diff/
> 
> 
> Testing
> -------
> 
> Tested manually that changing values in the dialog reflects in the preview.
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120511/811dc963/attachment.htm>