<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104919/">http://git.reviewboard.kde.org/r/104919/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Very good, and not even a single thing I could pick on.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104919/diff/1/?file=64064#file64064line198" style="color: black; font-weight: bold; text-decoration: underline;">plugins/textshape/dialogs/ParagraphGeneral.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ParagraphGeneral::save(KoParagraphStyle *style)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">190</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_paragraphDropCaps</span><span class="o">-></span><span class="n">save</span><span class="p">(</span><span class="n">style</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">174</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_paragraphDropCaps</span><span class="o">-></span><span class="n">save</span><span class="p">(</span><span class="n">s<span class="hl">avingS</span>tyle</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nice catch</pre>
</div>
<br />
<p>- C.</p>
<br />
<p>On May 11th, 2012, 6:57 p.m., Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated May 11, 2012, 6:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change enables us to use the actual textlayout code to render previews. This approach also enables us to remove a lot of redundant code that was there to substitute the layout process.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested manually that changing values in the dialog reflects in the preview.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/textlayout/KoStyleThumbnailer.h <span style="color: grey">(42c3c6d)</span></li>
<li>libs/textlayout/KoStyleThumbnailer.cpp <span style="color: grey">(acb836d)</span></li>
<li>plugins/textshape/dialogs/CharacterGeneral.h <span style="color: grey">(bb72b88)</span></li>
<li>plugins/textshape/dialogs/CharacterGeneral.cpp <span style="color: grey">(4923087)</span></li>
<li>plugins/textshape/dialogs/FormattingPreview.h <span style="color: grey">(5a67d48)</span></li>
<li>plugins/textshape/dialogs/FormattingPreview.cpp <span style="color: grey">(6103699)</span></li>
<li>plugins/textshape/dialogs/ParagraphBulletsNumbers.h <span style="color: grey">(03c5cc9)</span></li>
<li>plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp <span style="color: grey">(2d365f8)</span></li>
<li>plugins/textshape/dialogs/ParagraphDecorations.h <span style="color: grey">(0eea7cc)</span></li>
<li>plugins/textshape/dialogs/ParagraphDecorations.cpp <span style="color: grey">(b5c4d94)</span></li>
<li>plugins/textshape/dialogs/ParagraphDropCaps.h <span style="color: grey">(7c7b071)</span></li>
<li>plugins/textshape/dialogs/ParagraphDropCaps.cpp <span style="color: grey">(6696254)</span></li>
<li>plugins/textshape/dialogs/ParagraphGeneral.h <span style="color: grey">(5ef5c86)</span></li>
<li>plugins/textshape/dialogs/ParagraphGeneral.cpp <span style="color: grey">(8ef5b7f)</span></li>
<li>plugins/textshape/dialogs/ParagraphIndentSpacing.h <span style="color: grey">(27533e0)</span></li>
<li>plugins/textshape/dialogs/ParagraphIndentSpacing.cpp <span style="color: grey">(5227d55)</span></li>
<li>plugins/textshape/dialogs/ParagraphLayout.h <span style="color: grey">(be272ee)</span></li>
<li>plugins/textshape/dialogs/ParagraphLayout.cpp <span style="color: grey">(7b46f00)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104919/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>