Review Request: Make Paragraph Format dialog use KoStyleThumbnailer

Gopalakrishna Bhat gopalakbhat at gmail.com
Fri May 11 19:57:02 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104919/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

This change enables us to use the actual textlayout code to render previews. This approach also enables us to remove a lot of redundant code that was there to substitute the layout process.


Diffs
-----

  libs/textlayout/KoStyleThumbnailer.h 42c3c6d 
  libs/textlayout/KoStyleThumbnailer.cpp acb836d 
  plugins/textshape/dialogs/CharacterGeneral.h bb72b88 
  plugins/textshape/dialogs/CharacterGeneral.cpp 4923087 
  plugins/textshape/dialogs/FormattingPreview.h 5a67d48 
  plugins/textshape/dialogs/FormattingPreview.cpp 6103699 
  plugins/textshape/dialogs/ParagraphBulletsNumbers.h 03c5cc9 
  plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp 2d365f8 
  plugins/textshape/dialogs/ParagraphDecorations.h 0eea7cc 
  plugins/textshape/dialogs/ParagraphDecorations.cpp b5c4d94 
  plugins/textshape/dialogs/ParagraphDropCaps.h 7c7b071 
  plugins/textshape/dialogs/ParagraphDropCaps.cpp 6696254 
  plugins/textshape/dialogs/ParagraphGeneral.h 5ef5c86 
  plugins/textshape/dialogs/ParagraphGeneral.cpp 8ef5b7f 
  plugins/textshape/dialogs/ParagraphIndentSpacing.h 27533e0 
  plugins/textshape/dialogs/ParagraphIndentSpacing.cpp 5227d55 
  plugins/textshape/dialogs/ParagraphLayout.h be272ee 
  plugins/textshape/dialogs/ParagraphLayout.cpp 7b46f00 

Diff: http://git.reviewboard.kde.org/r/104919/diff/


Testing
-------

Tested manually that changing values in the dialog reflects in the preview.


Thanks,

Gopalakrishna Bhat

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120511/dc493c92/attachment.htm>


More information about the calligra-devel mailing list