Review Request: Fix bug 260535 - Shadow of the picture is not getting displayed.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104844/#review13398
-----------------------------------------------------------


This review has been submitted with commit ad02e25d9e4e11afc6e13ce813c4d4bd46a822ca by Inge Wallin to branch master.

- Commit Hook


On May 3, 2012, 9:38 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104844/
> -----------------------------------------------------------
> 
> (Updated May 3, 2012, 9:38 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch solves the problem that only shapes with a fill/background and/or a stroke can have a shadow. This was bad for the picture shape that most of the time had neither.
> 
> The design was made on irc, with the final solution outlined by zagge. I implemented his suggestion more or less out of the box.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.h 276c957 
>   libs/flake/KoShape.cpp 1789484 
>   libs/flake/KoShapeShadow.cpp 78c2111 
>   plugins/pictureshape/PictureShape.h 589ae6d 
>   plugins/pictureshape/PictureShape.cpp 66fa733 
> 
> Diff: http://git.reviewboard.kde.org/r/104844/diff/
> 
> 
> Testing
> -------
> 
> Tested with several shape types and they seem to work. And specifically with the test file in the bug.
> 
> If you test this with new shapes using the shadow tool, note that the default color for the new shadow has alpha=0, i.e. totally transparent. To be able to see the shadow you need to set alpha to something more solid.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120503/ee2975cb/attachment.htm>