Review Request: Text dragging in the textshapes

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104773/#review13394
-----------------------------------------------------------


The code looks good in general, just the small issues inside it. I don't know enough to know about the internal of either the text shape or the text tool to say much about the control flow.

Unfortunately I couldn't make the feature itself work. I could neither drag internally inside words or from words into another application. Dragging from kwrite into words worked though.



libs/kotext/KoTextEditor.cpp
<http://git.reviewboard.kde.org/r/104773/#comment10530>

    I think this name should be more specific.  What is within what? No way to tell without reading the code in detail. The same goes for m_position but to a slightly lesser degree.


- Inge Wallin


On April 29, 2012, 8:27 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104773/
> -----------------------------------------------------------
> 
> (Updated April 29, 2012, 8:27 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> I've implemented so you can drag text around in the text shape. It uses drag and drop so you can drag to and from other applications too
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoCanvasControllerWidgetViewport_p.cpp fab7c5c 
>   libs/flake/KoToolBase.h 0c0a9e4 
>   libs/flake/KoToolBase.cpp ae3482d 
>   libs/flake/KoToolProxy.h 8273980 
>   libs/flake/KoToolProxy.cpp 1e61e5c 
>   libs/kotext/KoTextDrag.h 9ad8560 
>   libs/kotext/KoTextDrag.cpp 5140785 
>   libs/kotext/KoTextEditor.h 616b320 
>   libs/kotext/KoTextEditor.cpp 60cff14 
>   libs/kotext/commands/ChangeTrackedDeleteCommand.cpp 562b726 
>   plugins/textshape/TextTool.h 5b42bb6 
>   plugins/textshape/TextTool.cpp 4078e72 
> 
> Diff: http://git.reviewboard.kde.org/r/104773/diff/
> 
> 
> Testing
> -------
> 
> Tried it as best I could to and from kate and internally in Words.
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120503/63a73374/attachment.htm>