<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104844/">http://git.reviewboard.kde.org/r/104844/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ad02e25d9e4e11afc6e13ce813c4d4bd46a822ca by Inge Wallin to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 3rd, 2012, 9:38 p.m., Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated May 3, 2012, 9:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch solves the problem that only shapes with a fill/background and/or a stroke can have a shadow. This was bad for the picture shape that most of the time had neither.
The design was made on irc, with the final solution outlined by zagge. I implemented his suggestion more or less out of the box.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with several shape types and they seem to work. And specifically with the test file in the bug.
If you test this with new shapes using the shadow tool, note that the default color for the new shadow has alpha=0, i.e. totally transparent. To be able to see the shadow you need to set alpha to something more solid.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShape.h <span style="color: grey">(276c957)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(1789484)</span></li>
<li>libs/flake/KoShapeShadow.cpp <span style="color: grey">(78c2111)</span></li>
<li>plugins/pictureshape/PictureShape.h <span style="color: grey">(589ae6d)</span></li>
<li>plugins/pictureshape/PictureShape.cpp <span style="color: grey">(66fa733)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104844/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>