<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104773/">http://git.reviewboard.kde.org/r/104773/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code looks good in general, just the small issues inside it. I don't know enough to know about the internal of either the text shape or the text tool to say much about the control flow.
Unfortunately I couldn't make the feature itself work. I could neither drag internally inside words or from words into another application. Dragging from kwrite into words worked though.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104773/diff/2/?file=59518#file59518line1680" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/KoTextEditor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1680</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="n">m_within</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this name should be more specific. What is within what? No way to tell without reading the code in detail. The same goes for m_position but to a slightly lesser degree.</pre>
</div>
<br />
<p>- Inge</p>
<br />
<p>On April 29th, 2012, 8:27 p.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated April 29, 2012, 8:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've implemented so you can drag text around in the text shape. It uses drag and drop so you can drag to and from other applications too</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tried it as best I could to and from kate and internally in Words.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoCanvasControllerWidgetViewport_p.cpp <span style="color: grey">(fab7c5c)</span></li>
<li>libs/flake/KoToolBase.h <span style="color: grey">(0c0a9e4)</span></li>
<li>libs/flake/KoToolBase.cpp <span style="color: grey">(ae3482d)</span></li>
<li>libs/flake/KoToolProxy.h <span style="color: grey">(8273980)</span></li>
<li>libs/flake/KoToolProxy.cpp <span style="color: grey">(1e61e5c)</span></li>
<li>libs/kotext/KoTextDrag.h <span style="color: grey">(9ad8560)</span></li>
<li>libs/kotext/KoTextDrag.cpp <span style="color: grey">(5140785)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(616b320)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(60cff14)</span></li>
<li>libs/kotext/commands/ChangeTrackedDeleteCommand.cpp <span style="color: grey">(562b726)</span></li>
<li>plugins/textshape/TextTool.h <span style="color: grey">(5b42bb6)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(4078e72)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104773/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>