Review Request: KoReport: fix save/load page margins

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105305/#review14908
-----------------------------------------------------------



libs/koreport/common/krreportdata.cpp
<http://git.reviewboard.kde.org/r/105305/#comment11701>

    good, please add "@todo add config for default margins or add within templates support"



libs/koreport/common/krreportdata.cpp
<http://git.reviewboard.kde.org/r/105305/#comment11702>

    shouldn't this be dpiX?



libs/koreport/common/krreportdata.cpp
<http://git.reviewboard.kde.org/r/105305/#comment11703>

    shouldn't this be dpiX?



libs/koreport/wrtembed/KoReportDesigner.cpp
<http://git.reviewboard.kde.org/r/105305/#comment11704>

    Good, but is saving other values proper then? e.g. report:page-width in line 316?


- Jarosław Staniek


On June 20, 2012, 10:46 a.m., Dag Andersen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105305/
> -----------------------------------------------------------
> 
> (Updated June 20, 2012, 10:46 a.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Seems page margins never worked:
> * Saveing used namespace fo, loading used report
> * Loading expected values in pt, saving was in localized value + unit
> 
> This changes:
> * Saving to use namespace 'fo' and value in points.
> * Loading to try to load any value + optional unit (with KoUnit::parseValue()).
> 
> 
> Diffs
> -----
> 
>   libs/koreport/common/krreportdata.cpp 4adf547 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 78dda97 
> 
> Diff: http://git.reviewboard.kde.org/r/105305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120620/26d1aa48/attachment.htm>