Review Request: KoReport: fix save/load page margins

[Dag Andersen]

> On June 20, 2012, 11:26 a.m., Jarosław Staniek wrote:
> > libs/koreport/wrtembed/KoReportDesigner.cpp, line 332
> > <http://git.reviewboard.kde.org/r/105305/diff/1/?file=69927#file69927line332>
> >
> >     Good, but is saving other values proper then? e.g. report:page-width in line 316?

Fixed (I hope), and fixed typos in attribute names.
But not tested, I can't set custom page size in plan.
And I doubt it has ever been used (?) afaics the typos means it could never work.


> On June 20, 2012, 11:26 a.m., Jarosław Staniek wrote:
> > libs/koreport/common/krreportdata.cpp, line 78
> > <http://git.reviewboard.kde.org/r/105305/diff/1/?file=69926#file69926line78>
> >
> >     good, please add "@todo add config for default margins or add within templates support"

Done


- Dag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105305/#review14908
-----------------------------------------------------------


On June 20, 2012, 10:46 a.m., Dag Andersen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105305/
> -----------------------------------------------------------
> 
> (Updated June 20, 2012, 10:46 a.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Seems page margins never worked:
> * Saveing used namespace fo, loading used report
> * Loading expected values in pt, saving was in localized value + unit
> 
> This changes:
> * Saving to use namespace 'fo' and value in points.
> * Loading to try to load any value + optional unit (with KoUnit::parseValue()).
> 
> 
> Diffs
> -----
> 
>   libs/koreport/common/krreportdata.cpp 4adf547 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 78dda97 
> 
> Diff: http://git.reviewboard.kde.org/r/105305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120621/4276753d/attachment.htm>