<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105305/">http://git.reviewboard.kde.org/r/105305/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105305/diff/1/?file=69926#file69926line78" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/common/krreportdata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoReportReportData::KoReportReportData(const QDomElement & elemSource, QObject *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">78</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">page</span><span class="p">.</span><span class="n">setMarginBottom</span><span class="p">(</span><span class="n">POINT_TO_INCH</span><span class="p">(</span><span class="n">KoUnit</span><span class="o">::</span><span class="n">parseValue</span><span class="p">(</span><span class="n">elemThis</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"fo:margin-bottom"</span><span class="p">,</span> <span class="s">"1.0cm"</span><span class="p">)))</span> <span class="o">*</span> <span class="n">KoDpi</span><span class="o">::</span><span class="n">dpiY</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">good, please add "@todo add config for default margins or add within templates support"</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105305/diff/1/?file=69926#file69926line80" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/common/krreportdata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoReportReportData::KoReportReportData(const QDomElement & elemSource, QObject *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">page</span><span class="p">.</span><span class="n">setMarginLeft</span><span class="p">(</span><span class="n">POINT_TO_INCH</span><span class="p">(</span><span class="n">KoUnit</span><span class="o">::</span><span class="n">parseValue</span><span class="p">(</span><span class="n">elemThis</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"fo:margin-left"</span><span class="p">,</span> <span class="s">"1.0cm"</span><span class="p">)))</span> <span class="o">*</span> <span class="n">KoDpi</span><span class="o">::</span><span class="n">dpiY</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shouldn't this be dpiX?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105305/diff/1/?file=69926#file69926line81" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/common/krreportdata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoReportReportData::KoReportReportData(const QDomElement & elemSource, QObject *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">page</span><span class="p">.</span><span class="n">setMarginRight</span><span class="p">(</span><span class="n">POINT_TO_INCH</span><span class="p">(</span><span class="n">KoUnit</span><span class="o">::</span><span class="n">parseValue</span><span class="p">(</span><span class="n">elemThis</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"fo:margin-right"</span><span class="p">,</span> <span class="s">"1.0cm"</span><span class="p">)))</span> <span class="o">*</span> <span class="n">KoDpi</span><span class="o">::</span><span class="n">dpiY</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shouldn't this be dpiX?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105305/diff/1/?file=69927#file69927line332" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QDomElement KoReportDesigner::document() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">332</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">pagestyle</span><span class="p">.</span><span class="n">setAttribute</span><span class="p">(</span><span class="s">"fo:margin-top"</span><span class="p">,</span> <span class="n">KoUnit</span><span class="o">::</span><span class="n">fromSymbol</span><span class="p">(</span><span class="n">m_topMargin</span><span class="o">-></span><span class="n">option</span><span class="p">(</span><span class="s">"unit"</span><span class="p">).</span><span class="n">toString</span><span class="p">()).</span><span class="n">toUserStringValue</span><span class="p">(</span><span class="n">m_topMargin</span><span class="o">-></span><span class="n">value</span><span class="p">().</span><span class="n">toDouble</span><span class="p">())</span> <span class="o">+</span> <span class="n">m_topMargin</span><span class="o">-></span><span class="n">option</span><span class="p">(</span><span class="s">"unit"</span><span class="p">).</span><span class="n">toString</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">332</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">pagestyle</span><span class="p">.</span><span class="n">setAttribute</span><span class="p">(</span><span class="s">"fo:margin-top"</span><span class="p">,</span> <span class="n">m_topMargin</span><span class="o">-></span><span class="n">value</span><span class="p">().</span><span class="n">toDouble</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good, but is saving other values proper then? e.g. report:page-width in line 316?</pre>
</div>
<br />
<p>- Jarosław</p>
<br />
<p>On June 20th, 2012, 10:46 a.m., Dag Andersen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Jarosław Staniek and Adam Pigg.</div>
<div>By Dag Andersen.</div>
<p style="color: grey;"><i>Updated June 20, 2012, 10:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems page margins never worked:
* Saveing used namespace fo, loading used report
* Loading expected values in pt, saving was in localized value + unit
This changes:
* Saving to use namespace 'fo' and value in points.
* Loading to try to load any value + optional unit (with KoUnit::parseValue()).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/common/krreportdata.cpp <span style="color: grey">(4adf547)</span></li>
<li>libs/koreport/wrtembed/KoReportDesigner.cpp <span style="color: grey">(78dda97)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105305/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>