Review Request: KexiDB: Remove limits for Text data type, leave as option

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105161/
-----------------------------------------------------------

(Updated June 7, 2012, 12:44 p.m.)


Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.


Changes
-------

Simplified the stuff after reviewing piggz's concerns.
Current behaviour:
* strategy can be either Default or Defined.
* all Field() constructors set Defined and by default set maxLength to 0 (unlimited)
* maxLengthStrategy does not affect values of maxLength, it's now only a hint that maxLength has been set based on value of defaultMaxLength.
* maxLength() returns just the current value (most important reason for reworking this feature - because changing maxLength is not a trivial thing in general; also changing maxLength should be always performed "by hand" if we want to make maxLength "following" user makes to global defaultMaxLength)
* to reset a field to default maximum length, call setMaxLength(defaultMaxLength()) and then to indicate this is based on default setting, call setMaxLengthStrategy(DefaultMaxLength)
* as we intend to backport this patch to 2.4, there is full backward compatibility and I did not add any support for defaultMaxLength in Kexi itself: fields follow default behavior of Field ctors, i.e. have Default strategy and maxLength == 0 (unlimited)
* this approach fixed most urgent part of https://bugs.kde.org/show_bug.cgi?id=301277, leaving option for 2.5


Description
-------

KexiDB: Remove limits for Text data type, leave as option

Now: by default there are no limits in Text data type


This addresses bug 301277.
    http://bugs.kde.org/show_bug.cgi?id=301277


Diffs (updated)
-----

  kexi/doc/dev/CHANGELOG-Kexi-js f4c055c 
  kexi/kexidb/alter.h 95b869e 
  kexi/kexidb/alter.cpp 447bb78 
  kexi/kexidb/connection.cpp 1eac0b9 
  kexi/kexidb/drivers/xbase/xbaseexport.cpp 08ddbe2 
  kexi/kexidb/expression.cpp d177834 
  kexi/kexidb/field.h 4db4b4e 
  kexi/kexidb/field.cpp f5cf3ab 
  kexi/kexidb/utils.cpp bb3f78c 
  kexi/migration/xbase/xbasemigrate.cpp cc434df 
  kexi/plugins/forms/widgets/kexidblineedit.cpp 9b2b98f 
  kexi/plugins/forms/widgets/kexidbtextedit.cpp eb3182b 
  kexi/plugins/scripting/kexidb/kexidbfield.cpp 442e4e9 
  kexi/plugins/tables/kexitabledesignerview.cpp a801bc7 
  kexi/plugins/tables/kexitabledesignerview_p.cpp 25f5b76 
  kexi/widget/tableview/kexiinputtableedit.cpp 9691390 

Diff: http://git.reviewboard.kde.org/r/105161/diff/


Testing
-------

Created new tables with fields of Text type, works.


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120607/04018960/attachment.htm>