<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105161/">http://git.reviewboard.kde.org/r/105161/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated June 7, 2012, 12:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simplified the stuff after reviewing piggz's concerns.
Current behaviour:
* strategy can be either Default or Defined.
* all Field() constructors set Defined and by default set maxLength to 0 (unlimited)
* maxLengthStrategy does not affect values of maxLength, it's now only a hint that maxLength has been set based on value of defaultMaxLength.
* maxLength() returns just the current value (most important reason for reworking this feature - because changing maxLength is not a trivial thing in general; also changing maxLength should be always performed "by hand" if we want to make maxLength "following" user makes to global defaultMaxLength)
* to reset a field to default maximum length, call setMaxLength(defaultMaxLength()) and then to indicate this is based on default setting, call setMaxLengthStrategy(DefaultMaxLength)
* as we intend to backport this patch to 2.4, there is full backward compatibility and I did not add any support for defaultMaxLength in Kexi itself: fields follow default behavior of Field ctors, i.e. have Default strategy and maxLength == 0 (unlimited)
* this approach fixed most urgent part of https://bugs.kde.org/show_bug.cgi?id=301277, leaving option for 2.5
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KexiDB: Remove limits for Text data type, leave as option
Now: by default there are no limits in Text data type</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created new tables with fields of Text type, works.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=301277">301277</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/doc/dev/CHANGELOG-Kexi-js <span style="color: grey">(f4c055c)</span></li>
<li>kexi/kexidb/alter.h <span style="color: grey">(95b869e)</span></li>
<li>kexi/kexidb/alter.cpp <span style="color: grey">(447bb78)</span></li>
<li>kexi/kexidb/connection.cpp <span style="color: grey">(1eac0b9)</span></li>
<li>kexi/kexidb/drivers/xbase/xbaseexport.cpp <span style="color: grey">(08ddbe2)</span></li>
<li>kexi/kexidb/expression.cpp <span style="color: grey">(d177834)</span></li>
<li>kexi/kexidb/field.h <span style="color: grey">(4db4b4e)</span></li>
<li>kexi/kexidb/field.cpp <span style="color: grey">(f5cf3ab)</span></li>
<li>kexi/kexidb/utils.cpp <span style="color: grey">(bb3f78c)</span></li>
<li>kexi/migration/xbase/xbasemigrate.cpp <span style="color: grey">(cc434df)</span></li>
<li>kexi/plugins/forms/widgets/kexidblineedit.cpp <span style="color: grey">(9b2b98f)</span></li>
<li>kexi/plugins/forms/widgets/kexidbtextedit.cpp <span style="color: grey">(eb3182b)</span></li>
<li>kexi/plugins/scripting/kexidb/kexidbfield.cpp <span style="color: grey">(442e4e9)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.cpp <span style="color: grey">(a801bc7)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview_p.cpp <span style="color: grey">(25f5b76)</span></li>
<li>kexi/widget/tableview/kexiinputtableedit.cpp <span style="color: grey">(9691390)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105161/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>