Review Request: KexiDB: Remove limits for Text data type, leave as option

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105161/#review14461
-----------------------------------------------------------



kexi/kexidb/field.h
<http://git.reviewboard.kde.org/r/105161/#comment11422>

    Please look at my comments below.



kexi/kexidb/field.cpp
<http://git.reviewboard.kde.org/r/105161/#comment11421>

    After I studied the current pqxx drv code:
    for 0 we have 'character varying' unlimited length - I think it's bug? we should have TEXT.
    
    for > 0 we have 'character varying(n)' in postgres, which is OK.
    
    Respecive f_length column in kexi__fields is now -1 what points to default max lenght, what is returned by exactly this global setting, and it is 'undefined'. So new fields from now should have TEXT unlimited setting. 
    I found it easier for casual developer; optimizations can be done afterwards. This leads to having LongText degraded - maybe meaningful for imported databases only but even then I am not sure. 
    The problem with LongText I had is that we cannot have global default alterable by user: now we can set the default to unlimited length or to any fixed length in one setting.


- Jarosław Staniek


On June 6, 2012, 12:45 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105161/
> -----------------------------------------------------------
> 
> (Updated June 6, 2012, 12:45 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> KexiDB: Remove limits for Text data type, leave as option
> 
> Now: by default there are no limits in Text data type
> 
> 
> This addresses bug 301277.
>     http://bugs.kde.org/show_bug.cgi?id=301277
> 
> 
> Diffs
> -----
> 
>   kexi/doc/dev/CHANGELOG-Kexi-js f4c055c8b21267de8f35e1ff4602a4daaa2b8eeb 
>   kexi/kexidb/alter.h 95b869e7d076e7caa5eb28c44b1d7e8272bfdff4 
>   kexi/kexidb/alter.cpp 447bb780346914cc1e3be591634f399659943a30 
>   kexi/kexidb/connection.cpp 1eac0b947fa8113c148e8b315a904fb982681752 
>   kexi/kexidb/drivers/xbase/xbaseexport.cpp 08ddbe22dfc5398e3541bf76266eab85516eb297 
>   kexi/kexidb/expression.cpp d177834bde4f1aaac5069da3fd99644ab4f0fee2 
>   kexi/kexidb/field.h 4db4b4e1570373f347ae37cda4ccc6b9c85e9898 
>   kexi/kexidb/field.cpp f5cf3ab0277b07d737d1e5c17711c0013c7446da 
>   kexi/kexidb/utils.cpp bb3f78ca984b39e28506280a1c81fdab633f4ce8 
>   kexi/migration/xbase/xbasemigrate.cpp cc434df83d79e6990cbd9b51a6509d37c76f06e2 
>   kexi/plugins/forms/widgets/kexidblineedit.cpp 9b2b98f0cf49a1613db76d125678ba838164dc0f 
>   kexi/plugins/forms/widgets/kexidbtextedit.cpp eb3182b13da2fe1ec7cf110c23cdbfc392745bdd 
>   kexi/plugins/scripting/kexidb/kexidbfield.cpp 442e4e91afcc9225efdc3e42969d442026fa9588 
>   kexi/plugins/tables/kexitabledesignerview.cpp a801bc721d78f1fcaeadc94bb1597a4c80b1b890 
>   kexi/plugins/tables/kexitabledesignerview_p.cpp 25f5b76e3190867fdfde7494dcdd9a558bc2e6f9 
>   kexi/widget/tableview/kexiinputtableedit.cpp 969139092f0fdc5b6a0c455ec73598c5da44384b 
> 
> Diff: http://git.reviewboard.kde.org/r/105161/diff/
> 
> 
> Testing
> -------
> 
> Created new tables with fields of Text type, works.
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120607/472eb1a4/attachment.htm>