<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105161/">http://git.reviewboard.kde.org/r/105161/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105161/diff/1/?file=66441#file66441line387" style="color: black; font-weight: bold; text-decoration: underline;">kexi/kexidb/field.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">387</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> 0 means "default length". */</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">382</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> Default is 0, i.e undefined. */</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please look at my comments below.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105161/diff/1/?file=66442#file66442line44" style="color: black; font-weight: bold; text-decoration: underline;">kexi/kexidb/field.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">static</span> <span class="n">uint</span> <span class="n">m_defaultMaxLength</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After I studied the current pqxx drv code:
for 0 we have 'character varying' unlimited length - I think it's bug? we should have TEXT.
for > 0 we have 'character varying(n)' in postgres, which is OK.
Respecive f_length column in kexi__fields is now -1 what points to default max lenght, what is returned by exactly this global setting, and it is 'undefined'. So new fields from now should have TEXT unlimited setting.
I found it easier for casual developer; optimizations can be done afterwards. This leads to having LongText degraded - maybe meaningful for imported databases only but even then I am not sure.
The problem with LongText I had is that we cannot have global default alterable by user: now we can set the default to unlimited length or to any fixed length in one setting.</pre>
</div>
<br />
<p>- Jarosław</p>
<br />
<p>On June 6th, 2012, 12:45 p.m., Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated June 6, 2012, 12:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KexiDB: Remove limits for Text data type, leave as option
Now: by default there are no limits in Text data type</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created new tables with fields of Text type, works.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=301277">301277</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/doc/dev/CHANGELOG-Kexi-js <span style="color: grey">(f4c055c8b21267de8f35e1ff4602a4daaa2b8eeb)</span></li>
<li>kexi/kexidb/alter.h <span style="color: grey">(95b869e7d076e7caa5eb28c44b1d7e8272bfdff4)</span></li>
<li>kexi/kexidb/alter.cpp <span style="color: grey">(447bb780346914cc1e3be591634f399659943a30)</span></li>
<li>kexi/kexidb/connection.cpp <span style="color: grey">(1eac0b947fa8113c148e8b315a904fb982681752)</span></li>
<li>kexi/kexidb/drivers/xbase/xbaseexport.cpp <span style="color: grey">(08ddbe22dfc5398e3541bf76266eab85516eb297)</span></li>
<li>kexi/kexidb/expression.cpp <span style="color: grey">(d177834bde4f1aaac5069da3fd99644ab4f0fee2)</span></li>
<li>kexi/kexidb/field.h <span style="color: grey">(4db4b4e1570373f347ae37cda4ccc6b9c85e9898)</span></li>
<li>kexi/kexidb/field.cpp <span style="color: grey">(f5cf3ab0277b07d737d1e5c17711c0013c7446da)</span></li>
<li>kexi/kexidb/utils.cpp <span style="color: grey">(bb3f78ca984b39e28506280a1c81fdab633f4ce8)</span></li>
<li>kexi/migration/xbase/xbasemigrate.cpp <span style="color: grey">(cc434df83d79e6990cbd9b51a6509d37c76f06e2)</span></li>
<li>kexi/plugins/forms/widgets/kexidblineedit.cpp <span style="color: grey">(9b2b98f0cf49a1613db76d125678ba838164dc0f)</span></li>
<li>kexi/plugins/forms/widgets/kexidbtextedit.cpp <span style="color: grey">(eb3182b13da2fe1ec7cf110c23cdbfc392745bdd)</span></li>
<li>kexi/plugins/scripting/kexidb/kexidbfield.cpp <span style="color: grey">(442e4e91afcc9225efdc3e42969d442026fa9588)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.cpp <span style="color: grey">(a801bc721d78f1fcaeadc94bb1597a4c80b1b890)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview_p.cpp <span style="color: grey">(25f5b76e3190867fdfde7494dcdd9a558bc2e6f9)</span></li>
<li>kexi/widget/tableview/kexiinputtableedit.cpp <span style="color: grey">(969139092f0fdc5b6a0c455ec73598c5da44384b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105161/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>