Review Request: Fix Bug 303003 - koreport: page sizes are not internationalized

[Dag Andersen]

> On July 7, 2012, 8:14 p.m., Jarosław Staniek wrote:
> > libs/koreport/wrtembed/KoReportDesigner.cpp, line 617
> > <http://git.reviewboard.kde.org/r/105469/diff/1/?file=71686#file71686line617>
> >
> >     A question to whole Calligra: do we have default page format? Or in KDE local settings? E.g. in the USA not having Letter as default would be annoying.

Yes, default comes from KGlobal::locale()


> On July 7, 2012, 8:14 p.m., Jarosław Staniek wrote:
> > libs/koreport/wrtembed/KoReportDesigner.h, line 299
> > <http://git.reviewboard.kde.org/r/105469/diff/1/?file=71685#file71685line299>
> >
> >     After looking at some cases in kdelibs, I propose:
> >     
> >     localizedPageFormatNames()
> >     
> >     pageFormatNames()
> >     
> >     If you look at your own doxygen descriptions, above method names reflect the descriptions a bit better.

It was used only once, so no argument from me :)


- Dag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105469/#review15532
-----------------------------------------------------------


On July 7, 2012, 9:03 a.m., Dag Andersen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105469/
> -----------------------------------------------------------
> 
> (Updated July 7, 2012, 9:03 a.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Uses page names defined in KoPageFormat.
> 
> 
> This addresses bug 303003.
>     http://bugs.kde.org/show_bug.cgi?id=303003
> 
> 
> Diffs
> -----
> 
>   libs/koreport/wrtembed/KoReportDesigner.h 747ea1d 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 262e6cd 
> 
> Diff: http://git.reviewboard.kde.org/r/105469/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120711/da9ce25c/attachment.htm>