Review Request: Fix Bug 303003 - koreport: page sizes are not internationalized

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105469/#review15532
-----------------------------------------------------------



libs/koreport/wrtembed/KoReportDesigner.h
<http://git.reviewboard.kde.org/r/105469/#comment12143>

    After looking at some cases in kdelibs, I propose:
    
    localizedPageFormatNames()
    
    pageFormatNames()
    
    If you look at your own doxygen descriptions, above method names reflect the descriptions a bit better.



libs/koreport/wrtembed/KoReportDesigner.cpp
<http://git.reviewboard.kde.org/r/105469/#comment12144>

    A question to whole Calligra: do we have default page format? Or in KDE local settings? E.g. in the USA not having Letter as default would be annoying.


- Jarosław Staniek


On July 7, 2012, 9:03 a.m., Dag Andersen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105469/
> -----------------------------------------------------------
> 
> (Updated July 7, 2012, 9:03 a.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Uses page names defined in KoPageFormat.
> 
> 
> This addresses bug 303003.
>     http://bugs.kde.org/show_bug.cgi?id=303003
> 
> 
> Diffs
> -----
> 
>   libs/koreport/wrtembed/KoReportDesigner.h 747ea1d 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 262e6cd 
> 
> Diff: http://git.reviewboard.kde.org/r/105469/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120707/3667497d/attachment.htm>