Review Request: Fix Bug 303003 - koreport: page sizes are not internationalized

Dag Andersen danders at get2net.dk
Wed Jul 11 11:37:11 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105469/
-----------------------------------------------------------

(Updated July 11, 2012, 10:37 a.m.)


Review request for Calligra, Jarosław Staniek and Adam Pigg.


Changes
-------

Updated patch:
Renamed allFormats(), allShortNames() as Staniek suggests
Removed pageFormatKeys(), pageFormatNames() from KoReportDesigner as they are not really needed.


Description
-------

Uses page names defined in KoPageFormat.


This addresses bug 303003.
    http://bugs.kde.org/show_bug.cgi?id=303003


Diffs (updated)
-----

  libs/koreport/wrtembed/KoReportDesigner.h 747ea1d 
  libs/koreport/wrtembed/KoReportDesigner.cpp f7f96a0 
  libs/odf/KoPageFormat.h 2aaa819 
  libs/odf/KoPageFormat.cpp cf4129b 
  libs/widgets/KoPageLayoutWidget.cpp 7169532 

Diff: http://git.reviewboard.kde.org/r/105469/diff/


Testing
-------


Thanks,

Dag Andersen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120711/f780707d/attachment.htm>


More information about the calligra-devel mailing list