Review Request: [kofficetests-odt/odf/odt/parag-decorations.odt] fixes wrong writing of double-border style also with a non-double border

Friedrich W. H. Kossebau kossebau at kde.org
Wed Jul 4 08:32:51 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105431/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

The property {Top,Bottom,Left,Right}BorderWidth is also set for single-line borders, so the current check e.g. "hasProperty(LeftBorderWidth)" will result in "style:border-line-width-left" being written for any style with a borderwidth != 0.

Attached patch fixes that, by instead checking if the border style is "double" and only then writing style:border-line-width*.

Okay to backport to 2.5?


Diffs
-----

  libs/kotext/styles/KoParagraphStyle.cpp 844903a 

Diff: http://git.reviewboard.kde.org/r/105431/diff/


Testing
-------

validateODF.py parag-decorations.odt gives zero output.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120704/da88143f/attachment.htm>


More information about the calligra-devel mailing list