(was: Re: [calligra] /: remove claim of CalligraParts to be real KParts/ReadOnlyPart, KParts/ReadWritePart)

Friedrich W. H. Kossebau kossebau at kde.org
Wed Jul 4 05:33:52 BST 2012


Am Dienstag, 3. Juli 2012, 21:13:55 schrieb Friedrich W.  H.  Kossebau:
> Git commit 92e6bb6583b43eb4d3d552f497931f6303323faf by Friedrich W. H.
> Kossebau. Committed on 03/07/2012 at 21:13.
> Pushed by kossebau into branch 'master'.
> 
> remove claim of CalligraParts to be real
> KParts/ReadOnlyPart,KParts/ReadWritePart
> 
> ATM none of the Calligra parts uses Part::setWidget(...) or reimplements
> Part::widget(). So all KPart supporting programs like Konqueror will 
crash
> when they try to get the widget from the part (and expect to get one).
> 
> REVIEW: 105425

This commit seems to have broken Calligra Active, cstester, 
calligraconverter and also the thumbnailer, jay, good strike, no? :)

Please double-check if the commits "Fixes: creation of KoDocument via 
KMimeTypeTrader fails with Part variant of createInstanceFromQuery(...)" to 
master and calligra/2.5 fixed all those for you as well again.

Cheers
Friedrich



More information about the calligra-devel mailing list