Review Request: [kofficetests-odt/odf/odt/parag-decorations.odt] fixes wrong writing of double-border style also with a non-double border

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105431/#review15466
-----------------------------------------------------------

Ship it!


good work and yes please backport

- C. Boemann


On July 4, 2012, 7:32 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105431/
> -----------------------------------------------------------
> 
> (Updated July 4, 2012, 7:32 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> The property {Top,Bottom,Left,Right}BorderWidth is also set for single-line borders, so the current check e.g. "hasProperty(LeftBorderWidth)" will result in "style:border-line-width-left" being written for any style with a borderwidth != 0.
> 
> Attached patch fixes that, by instead checking if the border style is "double" and only then writing style:border-line-width*.
> 
> Okay to backport to 2.5?
> 
> 
> Diffs
> -----
> 
>   libs/kotext/styles/KoParagraphStyle.cpp 844903a 
> 
> Diff: http://git.reviewboard.kde.org/r/105431/diff/
> 
> 
> Testing
> -------
> 
> validateODF.py parag-decorations.odt gives zero output.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120706/bcdc9945/attachment.htm>