Review Request: Fix z ordering of shapes inin background / foreground of text

C. Boemann cbr at boemann.dk
Tue Feb 14 08:37:14 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103971/
-----------------------------------------------------------

(Updated Feb. 14, 2012, 8:37 a.m.)


Review request for Calligra.


Changes
-------

unit tests fixed and patch somewhat simpler


Description
-------

The previous algorithm, took the values of the shape as the first "parent"

I've reordered the algo to only update the z and runThrough values when actually finding a parent.


Diffs (updated)
-----

  libs/flake/KoShape.cpp 26bdf2d 
  libs/flake/tests/TestShapeReorderCommand.cpp 09d6865 

Diff: http://git.reviewboard.kde.org/r/103971/diff/


Testing
-------

Not much, although it does solve the various small test documents i set out to fix


Thanks,

C. Boemann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120214/8bc6d25c/attachment.htm>


More information about the calligra-devel mailing list