Review Request: Fix z ordering of shapes inin background / foreground of text

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103971/#review10629
-----------------------------------------------------------

Ship it!


Run cstester and found some odt docs that get improved by the patch. No regressions. Good work.

- Thorsten Zachmann


On Feb. 14, 2012, 8:37 a.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103971/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2012, 8:37 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> The previous algorithm, took the values of the shape as the first "parent"
> 
> I've reordered the algo to only update the z and runThrough values when actually finding a parent.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.cpp 26bdf2d 
>   libs/flake/tests/TestShapeReorderCommand.cpp 09d6865 
> 
> Diff: http://git.reviewboard.kde.org/r/103971/diff/
> 
> 
> Testing
> -------
> 
> Not much, although it does solve the various small test documents i set out to fix
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120214/c46d466c/attachment.htm>