Review Request: Fix z ordering of shapes inin background / foreground of text

Thorsten Zachmann t.zachmann at zagge.de
Mon Feb 13 12:37:17 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103971/#review10595
-----------------------------------------------------------


The test libs-flake-TestShapePainting and libs-flake-TestShapeReorderCommand fail with th attached patch.

- Thorsten Zachmann


On Feb. 13, 2012, 12:18 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103971/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2012, 12:18 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> The previous algorithm, took the values of the shape as the first "parent"
> 
> I've reordered the algo to only update the z and runThrough values when actually finding a parent.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.cpp 26bdf2d 
> 
> Diff: http://git.reviewboard.kde.org/r/103971/diff/
> 
> 
> Testing
> -------
> 
> Not much, although it does solve the various small test documents i set out to fix
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120213/481e8258/attachment.htm>


More information about the calligra-devel mailing list