Review Request: Move the Create Path tool from flake/tools to plugins/defaulttools

[C. Boemann]

> On Dec. 11, 2012, 10:35 p.m., C. Boemann wrote:
> > plugins/defaultTools/createPathTool/KoCreatePathTool.cpp, line 373
> > <http://git.reviewboard.kde.org/r/107671/diff/1/?file=98368#file98368line373>
> >
> >     To possible other reviewers.
> >     
> >     I said this was okay, we are going to move the snap option widgets out into a docker (as per ui design discussions at Akademy)
> 
> Thorsten Zachmann wrote:
>     I think we should not remove the functionality until it is available due to a different form. I think we should keep it in.

Well true, but morice is already working on that in a branch that will also depend on this. We can merge everything into one review request but i found it nicer to have manageble sized review requests, and then live with disabled functionality for a few days.


- C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107671/#review23334
-----------------------------------------------------------


On Dec. 11, 2012, 10:29 p.m., Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107671/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2012, 10:29 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Move the Create Path tool from flake/tools to plugins/defaulttools
> 
> With Boemann we plan to make this tool load the stroke config widget. That's why we need it in the plug-ins and for now it's not used in the flake.
> 
> 
> Diffs
> -----
> 
>   libs/flake/CMakeLists.txt 62bc2dc 
>   libs/flake/KoToolRegistry.cpp 0ceb40e 
>   plugins/defaultTools/CMakeLists.txt 1f16010 
>   plugins/defaultTools/Plugin.cpp f811418 
>   plugins/defaultTools/createPathTool/KoCreatePathTool.h 5b0ae7e 
>   plugins/defaultTools/createPathTool/KoCreatePathTool.cpp 8dfbe34 
>   plugins/defaultTools/createPathTool/KoCreatePathToolFactory.h 1db235e 
>   plugins/defaultTools/createPathTool/KoCreatePathToolFactory.cpp f14139c 
> 
> Diff: http://git.reviewboard.kde.org/r/107671/diff/
> 
> 
> Testing
> -------
> 
> Tool tested after the move on the branch flake-movetools-morice.
> 
> 
> Thanks,
> 
> Jean-Nicolas Artaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121213/27dd3c9a/attachment.htm>