Review Request: Move the Create Path tool from flake/tools to plugins/defaulttools

Jean-Nicolas Artaud jeannicolasartaud at gmail.com
Tue Dec 18 09:27:20 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107671/
-----------------------------------------------------------

(Updated Dec. 18, 2012, 9:27 a.m.)


Review request for Calligra.


Changes
-------

This patch renames the KoCreatePathTool into CreatePathTool and remove useless comments and clean the code.


Description
-------

Move the Create Path tool from flake/tools to plugins/defaulttools

With Boemann we plan to make this tool load the stroke config widget. That's why we need it in the plug-ins and for now it's not used in the flake.


Diffs (updated)
-----

  libs/flake/tools/KoCreatePathTool.cpp 8dfbe34 
  libs/flake/tools/KoCreatePathTool.h 5b0ae7e 
  libs/flake/CMakeLists.txt 62bc2dc 
  libs/flake/KoToolRegistry.cpp 0ceb40e 
  krita/plugins/tools/selectiontools/kis_tool_select_path.cc e5d5995 
  krita/plugins/tools/selectiontools/kis_tool_select_path.h 9214159 
  krita/plugins/tools/selectiontools/kis_tool_select_magnetic.cc 33d6da7 
  krita/plugins/tools/selectiontools/kis_tool_select_magnetic.h d69c6b8 
  krita/plugins/tools/defaulttools/kis_tool_path.h f32ee61 
  krita/plugins/tools/defaulttools/kis_tool_path.cc a464af4 
  libs/flake/tools/KoCreatePathToolFactory.h 1db235e 
  libs/flake/tools/KoCreatePathToolFactory.cpp f14139c 
  libs/flake/tools/KoCreatePathTool_p.h 3bdedd7 
  plugins/defaultTools/CMakeLists.txt 1f16010 
  plugins/defaultTools/Plugin.cpp f811418 
  plugins/defaultTools/createPathTool/CreatePathTool.h PRE-CREATION 
  plugins/defaultTools/createPathTool/CreatePathTool.cpp PRE-CREATION 
  plugins/defaultTools/createPathTool/CreatePathToolFactory.h PRE-CREATION 
  plugins/defaultTools/createPathTool/CreatePathToolFactory.cpp PRE-CREATION 
  plugins/defaultTools/createPathTool/CreatePathTool_p.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107671/diff/


Testing
-------

Tool tested after the move on the branch flake-movetools-morice.


Thanks,

Jean-Nicolas Artaud

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121218/4c4a2fcd/attachment.htm>


More information about the calligra-devel mailing list