<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107671/">http://git.reviewboard.kde.org/r/107671/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 11th, 2012, 10:35 p.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107671/diff/1/?file=98368#file98368line373" style="color: black; font-weight: bold; text-decoration: underline;">plugins/defaultTools/createPathTool/KoCreatePathTool.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoCreatePathTool::addPathShape(KoPathShape *pathShape)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">373</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">SnapGuideConfigWidget</span> <span class="o">*</span><span class="n">widget</span> <span class="o">=</span> <span class="k">new</span> <span class="n">SnapGuideConfigWidget</span><span class="p">(</span><span class="n">canvas</span><span class="p">()</span><span class="o">-></span><span class="n">snapGuide</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">373</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl"> </span><span class="c1"><span class="hl">//</span> SnapGuideConfigWidget *widget = new SnapGuideConfigWidget(canvas()->snapGuide());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To possible other reviewers.
I said this was okay, we are going to move the snap option widgets out into a docker (as per ui design discussions at Akademy)</pre>
</blockquote>
<p>On December 13th, 2012, 4:09 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think we should not remove the functionality until it is available due to a different form. I think we should keep it in.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well true, but morice is already working on that in a branch that will also depend on this. We can merge everything into one review request but i found it nicer to have manageble sized review requests, and then live with disabled functionality for a few days.</pre>
<br />
<p>- C.</p>
<br />
<p>On December 11th, 2012, 10:29 p.m., Jean-Nicolas Artaud wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jean-Nicolas Artaud.</div>
<p style="color: grey;"><i>Updated Dec. 11, 2012, 10:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move the Create Path tool from flake/tools to plugins/defaulttools
With Boemann we plan to make this tool load the stroke config widget. That's why we need it in the plug-ins and for now it's not used in the flake.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tool tested after the move on the branch flake-movetools-morice.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/CMakeLists.txt <span style="color: grey">(62bc2dc)</span></li>
<li>libs/flake/KoToolRegistry.cpp <span style="color: grey">(0ceb40e)</span></li>
<li>plugins/defaultTools/CMakeLists.txt <span style="color: grey">(1f16010)</span></li>
<li>plugins/defaultTools/Plugin.cpp <span style="color: grey">(f811418)</span></li>
<li>plugins/defaultTools/createPathTool/KoCreatePathTool.h <span style="color: grey">(5b0ae7e)</span></li>
<li>plugins/defaultTools/createPathTool/KoCreatePathTool.cpp <span style="color: grey">(8dfbe34)</span></li>
<li>plugins/defaultTools/createPathTool/KoCreatePathToolFactory.h <span style="color: grey">(1db235e)</span></li>
<li>plugins/defaultTools/createPathTool/KoCreatePathToolFactory.cpp <span style="color: grey">(f14139c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107671/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>