Review Request: make sure we don't find more textranges than we ask for

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107621/#review23124
-----------------------------------------------------------


This review has been submitted with commit 824eac8accfc071c3a3b2baac4666e2d1049580c by C. Boemann to branch calligra/2.6.

- Commit Hook


On Dec. 7, 2012, 1:58 a.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107621/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2012, 1:58 a.m.)
> 
> 
> Review request for Calligra and Friedrich W. H. Kossebau.
> 
> 
> Description
> -------
> 
> Make the textRangesChangingWithin method actually check all that it's supposed to check
>     
> Normally we don't use this method in a too complex way so there should be no regressions,
> but still if bugs come up with saving too few textranges, this will be a patch to investigate
>     
> Basically we were only checking the matching tag against one of the parameters while we should be
> checking against both. I most case the our use is to have global match limits, so that is why we
> have not noticed the bug.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTextRangeManager.cpp 0940fda 
> 
> Diff: http://git.reviewboard.kde.org/r/107621/diff/
> 
> 
> Testing
> -------
> 
> None, except the skf test case, and some debug utput to see the method actually does what I want it to.
> 
> However there may be some regressions (espcialy in saving), because of changed behavour
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121207/dbd600a7/attachment.htm>