<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107621/">http://git.reviewboard.kde.org/r/107621/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 824eac8accfc071c3a3b2baac4666e2d1049580c by C. Boemann to branch calligra/2.6.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 7th, 2012, 1:58 a.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Friedrich W. H. Kossebau.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Dec. 7, 2012, 1:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make the textRangesChangingWithin method actually check all that it's supposed to check
Normally we don't use this method in a too complex way so there should be no regressions,
but still if bugs come up with saving too few textranges, this will be a patch to investigate
Basically we were only checking the matching tag against one of the parameters while we should be
checking against both. I most case the our use is to have global match limits, so that is why we
have not noticed the bug.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">None, except the skf test case, and some debug utput to see the method actually does what I want it to.
However there may be some regressions (espcialy in saving), because of changed behavour</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoTextRangeManager.cpp <span style="color: grey">(0940fda)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107621/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>