Review Request: This increases the flexibility of Statistics Docker Plugin , by allowing it to layout its widgets horizontally when user places it in the bottom area

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106252/#review18195
-----------------------------------------------------------



words/part/dockers/KWStatistics.h
<http://git.reviewboard.kde.org/r/106252/#comment14395>

    This is not the best place for placing attribute.



words/part/dockers/KWStatistics.cpp
<http://git.reviewboard.kde.org/r/106252/#comment14396>

    coding style...



words/part/dockers/KWStatisticsDocker.ui
<http://git.reviewboard.kde.org/r/106252/#comment14397>

    Upper case variable isn't allowed by guidelines. 



words/part/dockers/KWStatisticsDocker.ui
<http://git.reviewboard.kde.org/r/106252/#comment14398>

    1. All Caps is not the UI style, Only 1st word should be Uppercase.
    
    2. What does Flesch mean to casual user? How about using "Textual difficulty" instead? And Flesh reading ease as a tooltip/what's this/docs? If someone is curious what algorithm/methodology was used, she'll find out.
    


- Jarosław Staniek


On Aug. 28, 2012, 4:41 p.m., Shreya Pandit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106252/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2012, 4:41 p.m.)
> 
> 
> Review request for Calligra, Thomas Pfeiffer and Inge Wallin.
> 
> 
> Description
> -------
> 
> This allows the Statistics Docker to update its layout horizontally, when placed in bottom area. 
> 
> 
> Diffs
> -----
> 
>   words/part/dockers/StatisticsPreferencesPopup.h b481806 
>   words/part/dockers/StatisticsPreferencesPopup.cpp c741622 
>   words/part/dockers/KWStatisticsDocker.h fab6c7f 
>   words/part/dockers/KWStatisticsDocker.cpp 0bc8130 
>   words/part/dockers/KWStatisticsDocker.ui 63eaee5 
>   words/part/dockers/KWStatistics.h c480502 
>   words/part/dockers/KWStatistics.cpp a006d97 
> 
> Diff: http://git.reviewboard.kde.org/r/106252/diff/
> 
> 
> Testing
> -------
> 
> Checked for calligra words and calligra author
> 
> 
> Thanks,
> 
> Shreya Pandit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120828/c4429f3a/attachment.htm>