Review Request: This increases the flexibility of Statistics Docker Plugin , by allowing it to layout its widgets horizontally when user places it in the bottom area

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106252/#review18194
-----------------------------------------------------------


I agree with what Thomas says. There are also a few other things below.


words/part/dockers/KWStatistics.cpp
<http://git.reviewboard.kde.org/r/106252/#comment14394>

    The coding standard says spaces after "if" and before "{". This is relevant in more places in the patch.



words/part/dockers/KWStatisticsDocker.ui
<http://git.reviewboard.kde.org/r/106252/#comment14399>

    I'm not sure which screenshot Thomas is talking about but I agree that this group box seems unnecessary.  The layout should be enough. Also if there is any outer padding or margin, it could be set to something very small.


- Inge Wallin


On Aug. 28, 2012, 4:41 p.m., Shreya Pandit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106252/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2012, 4:41 p.m.)
> 
> 
> Review request for Calligra, Thomas Pfeiffer and Inge Wallin.
> 
> 
> Description
> -------
> 
> This allows the Statistics Docker to update its layout horizontally, when placed in bottom area. 
> 
> 
> Diffs
> -----
> 
>   words/part/dockers/StatisticsPreferencesPopup.h b481806 
>   words/part/dockers/StatisticsPreferencesPopup.cpp c741622 
>   words/part/dockers/KWStatisticsDocker.h fab6c7f 
>   words/part/dockers/KWStatisticsDocker.cpp 0bc8130 
>   words/part/dockers/KWStatisticsDocker.ui 63eaee5 
>   words/part/dockers/KWStatistics.h c480502 
>   words/part/dockers/KWStatistics.cpp a006d97 
> 
> Diff: http://git.reviewboard.kde.org/r/106252/diff/
> 
> 
> Testing
> -------
> 
> Checked for calligra words and calligra author
> 
> 
> Thanks,
> 
> Shreya Pandit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120828/402117ab/attachment.htm>