Review Request: This increases the flexibility of Statistics Docker Plugin , by allowing it to layout its widgets horizontally when user places it in the bottom area

Thomas Pfeiffer colomar at autistici.org
Tue Aug 28 19:34:17 BST 2012



> On Aug. 28, 2012, 5:10 p.m., Thomas Pfeiffer wrote:
> > The layout as such works pretty well.
> > However the screenshot shows the problem boemann and boud mentioned about placing dockers at the bottom: In their current design, they just have too much overhead with the titlebar. We'll have to see if a general solution to the problem can be found.
> > And the groupbox around the actual statistics looks odd and adds even more to the height. If possible you should remove it.

Also please replace the "Preferences" label with the "Configure" (wrench) icon


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106252/#review18172
-----------------------------------------------------------


On Aug. 28, 2012, 4:41 p.m., Shreya Pandit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106252/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2012, 4:41 p.m.)
> 
> 
> Review request for Calligra, Thomas Pfeiffer and Inge Wallin.
> 
> 
> Description
> -------
> 
> This allows the Statistics Docker to update its layout horizontally, when placed in bottom area. 
> 
> 
> Diffs
> -----
> 
>   words/part/dockers/StatisticsPreferencesPopup.h b481806 
>   words/part/dockers/StatisticsPreferencesPopup.cpp c741622 
>   words/part/dockers/KWStatisticsDocker.h fab6c7f 
>   words/part/dockers/KWStatisticsDocker.cpp 0bc8130 
>   words/part/dockers/KWStatisticsDocker.ui 63eaee5 
>   words/part/dockers/KWStatistics.h c480502 
>   words/part/dockers/KWStatistics.cpp a006d97 
> 
> Diff: http://git.reviewboard.kde.org/r/106252/diff/
> 
> 
> Testing
> -------
> 
> Checked for calligra words and calligra author
> 
> 
> Thanks,
> 
> Shreya Pandit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120828/0dfda594/attachment.htm>


More information about the calligra-devel mailing list