Review Request: add commands for chart operations

[Inge Wallin]

> On Aug. 19, 2012, 9:59 p.m., Inge Wallin wrote:
> > Yes, I agree with Boemann. This is fine and ok to commit after you fix the one thing that I commented on below.

Hmm, seems that review board removed my comment. It was that the coding standards demands spaces around operators. There are a number of places where it says "if (command!=0)...", which should be "if (command != 0) ..." instead.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106070/#review17725
-----------------------------------------------------------


On Aug. 18, 2012, 9:25 a.m., Brijesh Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106070/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2012, 9:25 a.m.)
> 
> 
> Review request for Calligra, Inge Wallin and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch adds commands for operations on axis, legend, dataset, textshape, etc. in charts
> 
> 
> Diffs
> -----
> 
>   plugins/chartshape/CMakeLists.txt 4d930df 
>   plugins/chartshape/ChartConfigWidget.h 748bafa 
>   plugins/chartshape/ChartConfigWidget.cpp fbce6b8 
>   plugins/chartshape/ChartShape.h e3c7750 
>   plugins/chartshape/ChartShape.cpp a8a60db 
>   plugins/chartshape/ChartTool.h 3a4a292 
>   plugins/chartshape/ChartTool.cpp e59c281 
>   plugins/chartshape/Legend.h 6c4daf2 
>   plugins/chartshape/Legend.cpp 8c73bf0 
>   plugins/chartshape/commands/AxisCommand.h PRE-CREATION 
>   plugins/chartshape/commands/AxisCommand.cpp PRE-CREATION 
>   plugins/chartshape/commands/ChartTextShapeCommand.h PRE-CREATION 
>   plugins/chartshape/commands/ChartTextShapeCommand.cpp PRE-CREATION 
>   plugins/chartshape/commands/DatasetCommand.h PRE-CREATION 
>   plugins/chartshape/commands/DatasetCommand.cpp PRE-CREATION 
>   plugins/chartshape/commands/LegendCommand.h PRE-CREATION 
>   plugins/chartshape/commands/LegendCommand.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106070/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brijesh Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120819/39bf7520/attachment.htm>