Review Request: add commands for chart operations

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106070/#review17730
-----------------------------------------------------------



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13873>

    The new can't fail in a way that command will be 0 so there is no need to check for it.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13876>

    Would it make sense to have a constructor that takes the different values the command set as parameter. Then there would be no need to call it with the setDataSet command?



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13874>

    The check is not needed



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13875>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13877>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13878>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13879>

    The check is not needed



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13880>

    The check is not needed



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13881>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13882>

    The check is not needed



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13883>

    The check is not needed



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13884>

    The check is not needed



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13885>

    The check is not needed



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13886>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13887>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13888>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13889>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13890>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13891>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13892>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13893>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13894>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13895>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13896>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13897>

    The check is not needed.



plugins/chartshape/ChartTool.cpp
<http://git.reviewboard.kde.org/r/106070/#comment13898>

    The check is not needed.



plugins/chartshape/commands/ChartTextShapeCommand.h
<http://git.reviewboard.kde.org/r/106070/#comment13899>

    As there is only one set value I think it makes sense to pass the new value in the constructor.


- Thorsten Zachmann


On Aug. 18, 2012, 9:25 a.m., Brijesh Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106070/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2012, 9:25 a.m.)
> 
> 
> Review request for Calligra, Inge Wallin and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch adds commands for operations on axis, legend, dataset, textshape, etc. in charts
> 
> 
> Diffs
> -----
> 
>   plugins/chartshape/CMakeLists.txt 4d930df 
>   plugins/chartshape/ChartConfigWidget.h 748bafa 
>   plugins/chartshape/ChartConfigWidget.cpp fbce6b8 
>   plugins/chartshape/ChartShape.h e3c7750 
>   plugins/chartshape/ChartShape.cpp a8a60db 
>   plugins/chartshape/ChartTool.h 3a4a292 
>   plugins/chartshape/ChartTool.cpp e59c281 
>   plugins/chartshape/Legend.h 6c4daf2 
>   plugins/chartshape/Legend.cpp 8c73bf0 
>   plugins/chartshape/commands/AxisCommand.h PRE-CREATION 
>   plugins/chartshape/commands/AxisCommand.cpp PRE-CREATION 
>   plugins/chartshape/commands/ChartTextShapeCommand.h PRE-CREATION 
>   plugins/chartshape/commands/ChartTextShapeCommand.cpp PRE-CREATION 
>   plugins/chartshape/commands/DatasetCommand.h PRE-CREATION 
>   plugins/chartshape/commands/DatasetCommand.cpp PRE-CREATION 
>   plugins/chartshape/commands/LegendCommand.h PRE-CREATION 
>   plugins/chartshape/commands/LegendCommand.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106070/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brijesh Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120820/dbbe1686/attachment.htm>