<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106070/">http://git.reviewboard.kde.org/r/106070/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2012, 9:59 p.m., <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I agree with Boemann. This is fine and ok to commit after you fix the one thing that I commented on below.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, seems that review board removed my comment. It was that the coding standards demands spaces around operators. There are a number of places where it says "if (command!=0)...", which should be "if (command != 0) ..." instead.</pre>
<br />
<p>- Inge</p>
<br />
<p>On August 18th, 2012, 9:25 a.m., Brijesh Patel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Inge Wallin and C. Boemann.</div>
<div>By Brijesh Patel.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2012, 9:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds commands for operations on axis, legend, dataset, textshape, etc. in charts</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/chartshape/CMakeLists.txt <span style="color: grey">(4d930df)</span></li>
<li>plugins/chartshape/ChartConfigWidget.h <span style="color: grey">(748bafa)</span></li>
<li>plugins/chartshape/ChartConfigWidget.cpp <span style="color: grey">(fbce6b8)</span></li>
<li>plugins/chartshape/ChartShape.h <span style="color: grey">(e3c7750)</span></li>
<li>plugins/chartshape/ChartShape.cpp <span style="color: grey">(a8a60db)</span></li>
<li>plugins/chartshape/ChartTool.h <span style="color: grey">(3a4a292)</span></li>
<li>plugins/chartshape/ChartTool.cpp <span style="color: grey">(e59c281)</span></li>
<li>plugins/chartshape/Legend.h <span style="color: grey">(6c4daf2)</span></li>
<li>plugins/chartshape/Legend.cpp <span style="color: grey">(8c73bf0)</span></li>
<li>plugins/chartshape/commands/AxisCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/commands/AxisCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/commands/ChartTextShapeCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/commands/ChartTextShapeCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/commands/DatasetCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/commands/DatasetCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/commands/LegendCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/commands/LegendCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106070/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>