Review Request: Add support for 3D scenes to libs/odf

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104688/
-----------------------------------------------------------

(Updated April 23, 2012, 6:40 p.m.)


Review request for Calligra.


Changes
-------

Next version.  
 - d-pointer, all implementation in the .cpp
 - removed lots of spaces
 - user of the code (chart plot area)
 - no "" as default values
 - all in a branch: libs-3ds-ingwa


I tested with creating a 3D chart in ooimpress and roundtrip it through Stage. It worked so-so because the chart shape sucks at saving but all of the 3d attributes were retained.


Description
-------

This new code adds support for 3D scenes in libs/odf. It was ported from my threedscene branch when I found out that exactly the same attributes are used in 3D charts.

The only tricky thing with this code is that the attributes are not stored in a style but in the actual elements (dr3d:scene and chart:plot-area respectively). This means that we have to save the attributes and the children separately since the saving code of these objects may want to add other attributes *and* children.

You may note that I didn't d-pointer-ify the class.  Right now the odf library is not binary compatibility frozen so I don't strictly need to but if there is a strong wish for it I can do it.


Diffs (updated)
-----

  libs/odf/CMakeLists.txt c411a8c 
  libs/odf/Ko3dScene.h PRE-CREATION 
  libs/odf/Ko3dScene.cpp PRE-CREATION 
  plugins/chartshape/CMakeLists.txt a671908 
  plugins/chartshape/PlotArea.h 90c4b91 
  plugins/chartshape/PlotArea.cpp b0c108b 
  plugins/chartshape/ThreeDScene.h b77c32d 
  plugins/chartshape/ThreeDScene.cpp b1fec80 
  plugins/chartshape/ThreeDTransformation.h f03163a 
  plugins/chartshape/ThreeDTransformation.cpp 8f1e5ec 

Diff: http://git.reviewboard.kde.org/r/104688/diff/


Testing
-------

I have tested this code while working on the 3D Scene shape.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120423/5440874a/attachment.htm>