<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104688/">http://git.reviewboard.kde.org/r/104688/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated April 23, 2012, 6:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Next version.
- d-pointer, all implementation in the .cpp
- removed lots of spaces
- user of the code (chart plot area)
- no "" as default values
- all in a branch: libs-3ds-ingwa
I tested with creating a 3D chart in ooimpress and roundtrip it through Stage. It worked so-so because the chart shape sucks at saving but all of the 3d attributes were retained.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This new code adds support for 3D scenes in libs/odf. It was ported from my threedscene branch when I found out that exactly the same attributes are used in 3D charts.
The only tricky thing with this code is that the attributes are not stored in a style but in the actual elements (dr3d:scene and chart:plot-area respectively). This means that we have to save the attributes and the children separately since the saving code of these objects may want to add other attributes *and* children.
You may note that I didn't d-pointer-ify the class. Right now the odf library is not binary compatibility frozen so I don't strictly need to but if there is a strong wish for it I can do it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested this code while working on the 3D Scene shape.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/odf/CMakeLists.txt <span style="color: grey">(c411a8c)</span></li>
<li>libs/odf/Ko3dScene.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/odf/Ko3dScene.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/CMakeLists.txt <span style="color: grey">(a671908)</span></li>
<li>plugins/chartshape/PlotArea.h <span style="color: grey">(90c4b91)</span></li>
<li>plugins/chartshape/PlotArea.cpp <span style="color: grey">(b0c108b)</span></li>
<li>plugins/chartshape/ThreeDScene.h <span style="color: grey">(b77c32d)</span></li>
<li>plugins/chartshape/ThreeDScene.cpp <span style="color: grey">(b1fec80)</span></li>
<li>plugins/chartshape/ThreeDTransformation.h <span style="color: grey">(f03163a)</span></li>
<li>plugins/chartshape/ThreeDTransformation.cpp <span style="color: grey">(8f1e5ec)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104688/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>