Review Request: Add support for 3D scenes to libs/odf

[Inge Wallin]

> On April 22, 2012, 5:08 a.m., Thorsten Zachmann wrote:
> > libs/odf/Ko3dScene.cpp, line 150
> > <http://git.reviewboard.kde.org/r/104688/diff/1/?file=58309#file58309line150>
> >
> >     The save method of the Ko3dScene should also save the tag drd3:screen tag.
> 
> Inge Wallin wrote:
>     dr3d:screen doesn't exist. At least I couldn't find it in ODF 1.2.  Where did you see that?
> 
> Thorsten Zachmann wrote:
>     Sorry that was a typo. I meant the dr3d:scene tag should be saved.

Aha.  No, it shouldn't, actually.  Because the very reason this is now proposed to libs/odf instead of just staying in my 3D shape is because the same attributes and children are used in chart:plot-area.  So it would defeat the purpose to do that.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104688/#review12773
-----------------------------------------------------------


On April 21, 2012, 12:39 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104688/
> -----------------------------------------------------------
> 
> (Updated April 21, 2012, 12:39 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This new code adds support for 3D scenes in libs/odf. It was ported from my threedscene branch when I found out that exactly the same attributes are used in 3D charts.
> 
> The only tricky thing with this code is that the attributes are not stored in a style but in the actual elements (dr3d:scene and chart:plot-area respectively). This means that we have to save the attributes and the children separately since the saving code of these objects may want to add other attributes *and* children.
> 
> You may note that I didn't d-pointer-ify the class.  Right now the odf library is not binary compatibility frozen so I don't strictly need to but if there is a strong wish for it I can do it.
> 
> 
> Diffs
> -----
> 
>   libs/odf/CMakeLists.txt c411a8c 
>   libs/odf/Ko3dScene.h PRE-CREATION 
>   libs/odf/Ko3dScene.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104688/diff/
> 
> 
> Testing
> -------
> 
> I have tested this code while working on the 3D Scene shape.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120422/8e9af2bd/attachment.htm>