Review Request: Fix drawing of shadows for shapes

C. Boemann cbr at boemann.dk
Sat Apr 21 20:30:26 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104615/
-----------------------------------------------------------

(Updated April 21, 2012, 7:30 p.m.)


Review request for Calligra, Yue Liu, Jan Hambrecht, and Thorsten Zachmann.


Changes
-------

Completely new take on the solution

Tested and every thing seems to work except the bounding box used by default tools seem to be wrong, though this is not related to what i'm solving here


Description
-------

There were a number of problems in the previous code that made shapes be cut off as can be seen in https://bugs.kde.org/show_bug.cgi?id=273500

This fixes that


Diffs (updated)
-----

  libs/flake/KoShapeGroup.cpp 76e4212 
  libs/flake/KoShapeShadow.cpp 431ee78 

Diff: http://git.reviewboard.kde.org/r/104615/diff/


Testing
-------

Tried shadows in all directions with and without blur. in Words (both anchored and non anchored), and in Stage

It appears to just work.


Thanks,

C. Boemann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120421/a2ddf82f/attachment.htm>


More information about the calligra-devel mailing list