Review Request: Fix drawing of shadows for shapes

Thorsten Zachmann t.zachmann at zagge.de
Wed Apr 18 05:01:38 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104615/#review12625
-----------------------------------------------------------


I found a problem with the drawing of the shadow of a rotated rectangle. See the file 

http://www.zagge.de/files/shadow-problem.odp

for the problem. Somehow the shadow of the rotated shape is clipped. Seems not to happen if I use a square shape.

- Thorsten Zachmann


On April 17, 2012, 10:32 a.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104615/
> -----------------------------------------------------------
> 
> (Updated April 17, 2012, 10:32 a.m.)
> 
> 
> Review request for Calligra, Yue Liu, Jan Hambrecht, and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> There were a number of problems in the previous code that made shapes be cut off as can be seen in https://bugs.kde.org/show_bug.cgi?id=273500
> 
> This fixes that
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeShadow.cpp 431ee78 
> 
> Diff: http://git.reviewboard.kde.org/r/104615/diff/
> 
> 
> Testing
> -------
> 
> Tried shadows in all directions with and without blur. in Words (both anchored and non anchored), and in Stage
> 
> It appears to just work.
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120418/0f9a640f/attachment.htm>


More information about the calligra-devel mailing list